Allow CommandMetadata to be injected into Cli commands #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows HelpOption to be used with commands via Cli.parse
| @@ -123,7 +123,7 @@ public C parse(Iterable<String> args) | |||
| command.getArguments(), | |||
| state.getParsedArguments(), | |||
| command.getMetadataInjections(), | |||
| ImmutableMap.<Class<?>, Object>of(GlobalMetadata.class, metadata)); | |||
| ImmutableMap.<Class<?>, Object>of(GlobalMetadata.class, metadata, CommandMetadata.class, command)); | |||
There was a problem hiding this comment.
I think this should inject CommandGroupMetadata as well -- I did a pull request for this before I discovered yours: #35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
HelpOptionto be used with commands viaCli.parse.Without this, attempting to use
HelpOptionwith a command via theCliclass instead ofSingleCommandresults in aNullPointerExceptionwhenHelpOption.showHelpIfRequested()is called. This commit allows the patterngit add -hto show help correctly.